Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightgbm_pipeliens_models&tests #40

Conversation

NickNtamp
Copy link
Contributor

@NickNtamp NickNtamp commented Nov 4, 2022

You can find also the trained models in pickle format. I commented-out the saving option there.
The training is taking less than 2s at least in local machine.

Also I believe that we have to change the code in the spot that we save to model in a local repo file and to add an integration with S3 or something.

Copy link
Member

@momegas momegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comments is that the models should no be git tracked.
Every user will train their own, so it doesnt make sense to keep them
Other than that its great 👍

@gcharis gcharis merged commit d9b0a47 into main Nov 9, 2022
@momegas momegas deleted the 36-create-pipeline-that-given-the-training-dataset-for-classification-trains-a-decision-tree-based-model-lightgbm-xgboost-or-similar branch November 18, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants