-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation and tests setup #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess it's OK. I really need to get in depth with that SDK thing.
P.S.: Nice changing "many" to "batch" in inferences API. Was on my mind for quite some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
The approach in the setup is to mock requests and test the SDK this way.
The reason is that
TestClient
does some magic and does not run the API exposing the host and port. I found it quite complex to run the API like this so I went with the simple way of mocking the back end.