New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zero length files are ignored #1

Open

blanknut opened this issue Oct 29, 2018 · 0 comments

Assignees

Labels

bug

blanknut commented Oct 29, 2018

I had troubles with zero length files and I think there is an error in method Files() in Container/Jar.cs. As far as I have understood the code, the test "e.Length != 0" is to filter out directories. If this is the case, it's not correct, see:
https://stackoverflow.com/questions/40223451/how-to-tell-if-a-ziparchiveentry-is-directory

This bug results in wrong nonStandardCountCheck's in Verify.cs, see line 131:
if (centralManifest.Entries.Count != nonManifestFiles)

DavidR91 self-assigned this

DavidR91 added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment