Merge pull request #132 from squat/172-16-slash-12

pkg/mesh: correctly check 172.16/12 IP range
squat · Mar 6, 2021 · 251e8fa · 251e8fa
2 parents 90a2540 + 39803ce
commit 251e8fa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/mesh/ip.go b/pkg/mesh/ip.go
@@ -47,7 +47,7 @@ func isPublic(ip net.IP) bool {
 		case ip4[0] == 10:
 			return false
 		// Check for 172.16.0.0/12.
-		case ip4[0] == 172 && ip4[1]&0xf0 != 0:
+		case ip4[0] == 172 && ip4[1]&0xf0 == 0x10:
 			return false
 		// Check for 192.168.0.0/16.
 		case ip4[0] == 192 && ip4[1] == 168:

diff --git a/pkg/mesh/ip_test.go b/pkg/mesh/ip_test.go
@@ -154,6 +154,11 @@ func TestIsPublic(t *testing.T) {
 			ip:   net.ParseIP("172.15.255.255"),
 			out:  true,
 		},
+		{
+			name: "above 172.16/12",
+			ip:   net.ParseIP("172.160.255.255"),
+			out:  true,
+		},
 		{
 			name: "192.168/16",
 			ip:   net.ParseIP("192.168.0.0"),