Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/gen-docs/main.go: auto generate docs for CRD #169

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

leonnicolas
Copy link
Collaborator

The new make command make gen-docs is introduced.
It will build a markdown file from the CRD introduced by Kilo.

The generation of the docs is a requirement for building the website.

Signed-off-by: leonnicolas leonloechner@gmx.de

Copy link
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I have some small suggestions, otherwise LGTM

Makefile Outdated Show resolved Hide resolved
cmd/gen-docs/main.go Outdated Show resolved Hide resolved
cmd/gen-docs/main.go Outdated Show resolved Hide resolved
cmd/gen-docs/main.go Outdated Show resolved Hide resolved
cmd/gen-docs/main.go Outdated Show resolved Hide resolved
cmd/gen-docs/main.go Outdated Show resolved Hide resolved
The new make command `make gen-docs` is introduced.
It will build a markdown file from the CRD introduced by Kilo.

The generation of the docs is a requirement for building the website.

Signed-off-by: leonnicolas <leonloechner@gmx.de>
Copy link
Owner

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazinggggg

@squat squat merged commit 9f37a93 into main May 17, 2021
@squat squat deleted the generate_CRD branch May 17, 2021 15:30
@squat squat mentioned this pull request May 21, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants