docs/building.md: add docs for building Kilo and the website #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
leonnicolas
commented
May 22, 2021
squat
reviewed
May 25, 2021
There was a problem hiding this comment.
Thanks @leonnicolas for taking a crack at this, it was really overdue for the project. I added some style suggestions. Let me know what you think :)
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
docs/building_kilo.md
Outdated
| docker run --rm --privileged multiarch/qemu-user-static --reset -p yes | ||
| ``` | ||
|
|
||
| To be able to upload test containers of Kilo to your docker hub repository `make manifest`, run: |
There was a problem hiding this comment.
It looks like this might be combining two instructions into one
squat
reviewed
May 27, 2021
squat
reviewed
May 27, 2021
leonnicolas
force-pushed
the
docs_build
branch
2 times, most recently
from
8ada613
to
f828354
Compare
Signed-off-by: leonnicolas <leonloechner@gmx.de> Update docs/building_kilo.md Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
Co-authored-by: Lucas Servén Marín <lserven@gmail.com>
squat
approved these changes
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.