Add metrics for iptables operations #323
Conversation
Co-authored-by: leonnicolas <60091705+leonnicolas@users.noreply.github.com>
pkg/iptables/metrics.go
Outdated
| "operation", | ||
| "table", | ||
| }) | ||
| registerer.MustRegister(counterWithChain, counterWithoutChain) |
There was a problem hiding this comment.
if we do the registerer == nil check here, we don't have to do it in the caller twice (for ipv4 and ipv6)
There was a problem hiding this comment.
@clive-jevons WDYT? I don't feel it's the cleanest piece of code ever to hand in a nil value for registerer here, but I have no strong feelings against it either...
Co-authored-by: leonnicolas <60091705+leonnicolas@users.noreply.github.com>
| @@ -245,7 +245,7 @@ func runRoot(_ *cobra.Command, _ []string) error { | |||
| if port < 1 || port > 1<<16-1 { | |||
| return fmt.Errorf("invalid port: port mus be in range [%d:%d], but got %d", 1, 1<<16-1, port) | |||
| } | |||
| m, err := mesh.New(b, enc, gr, hostname, port, s, local, cni, cniPath, iface, cleanUpIface, createIface, mtu, resyncPeriod, prioritisePrivateAddr, iptablesForwardRule, log.With(logger, "component", "kilo")) | |||
| m, err := mesh.New(b, enc, gr, hostname, port, s, local, cni, cniPath, iface, cleanUpIface, createIface, mtu, resyncPeriod, prioritisePrivateAddr, iptablesForwardRule, log.With(logger, "component", "kilo"), registry) | |||
There was a problem hiding this comment.
Since the mesh accepts a registerer in its constructor, I think it's pretty awkward to still require calling "RegisterMetrics" a couple of lines below. We should do this automatically now during creation of the mesh.
I'll add it over the weekend! 👍 |
|
Thanks @dajudge and great work here |
|
I'm a bit puzzled why those e2e tests would fail... 🤔 |
|
Retried the e2e tests and it passed; I think the failure was just a flake |
|
Netlify also passed but the status isn't syncing. Merging 🚀🚀 |
To have better visibility of the iptables operations performed by kilo it would be nice to have prom metrics for them.
This PR introduces such metrics for all iptables operations by wrapping a proxy around the iptables client.