pkg/mesh: avoid NAT-ing packets to service CIDRs #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, packets to service CIDRs may be masqueraded because they are IP addresses that Kilo does not know about and therefore is not sure if they know about some Kilo IPs, e.g. Peer IPs. This is not terrible but it is annoying and can prevent some advanced use-cases, see #330. This commit adds an optional flag to the `kg` binary that can be given multiple times to specify the service CIDRs of the cluster so that Kilo does not masquerade packets to them. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat
force-pushed
the
avoid_nat_service_cidr
branch
from
f39f2ee
to
25989a8
Compare
|
Ping @leonnicolas |
|
Merging to unblock #330 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, packets to service CIDRs may be masqueraded because they are
IP addresses that Kilo does not know about and therefore is not sure if
they know about some Kilo IPs, e.g. Peer IPs. This is not terrible but
it is annoying and can prevent some advanced use-cases, see #330. This
commit adds an optional flag to the
kgbinary that can be givenmultiple times to specify the service CIDRs of the cluster so that Kilo
does not masquerade packets to them.
Signed-off-by: Lucas Servén Marín lserven@gmail.com