Expose MACs of private networks in instance resource #54
Comments
mlazowik
changed the title
|
A separate |
|
@mlazowik it’s unfortunate, but it’s ok to introduce a breaking API change. The API is not yet stable and this is exactly the right time to be introducing new features that help make this provider a fully featured plugin that is useful for all scenarios. If you’d like to have a go at writing the new feature, I would be more than happy to review it :) |
|
Sure, I'll take a stab at that. I wonder how the state file will react to this, it should auto update on next |
mlazowik
added a commit
to qedsoftware/terraform-provider-vultr
that referenced
this issue
Dec 5, 2018
Terraform will support nested maps starting with 0.12 (late summer), so I'm adding a separate map of MACs. https://www.hashicorp.com/blog/terraform-0-12-rich-value-types Fixes squat#54
mlazowik
added a commit
to qedsoftware/terraform-provider-vultr
that referenced
this issue
Dec 5, 2018
Terraform will support nested maps starting with 0.12 (late summer), so I'm adding a separate map of MACs. https://www.hashicorp.com/blog/terraform-0-12-rich-value-types Fixes squat#54
mlazowik
added a commit
to qedsoftware/terraform-provider-vultr
that referenced
this issue
Dec 5, 2018
Terraform will support nested maps starting with 0.12 (late summer), so I'm adding a separate map of MACs. https://www.hashicorp.com/blog/terraform-0-12-rich-value-types Fixes squat#54
mlazowik
added a commit
to qedsoftware/terraform-provider-vultr
that referenced
this issue
Dec 28, 2018
Terraform will support nested maps starting with 0.12 (late summer), so I'm adding a separate map of MACs. https://www.hashicorp.com/blog/terraform-0-12-rich-value-types Fixes squat#54
squat
pushed a commit
to qedsoftware/terraform-provider-vultr
that referenced
this issue
Jan 8, 2019
Terraform will support nested maps starting with 0.12 (late summer), so I'm adding a separate map of MACs. https://www.hashicorp.com/blog/terraform-0-12-rich-value-types Fixes squat#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Around here: https://github.com/squat/terraform-provider-vultr/blob/master/vultr/resource_instance.go#L276
The question is how to do this without breaking the API? Right know each private network value is just its IP, switching this to an object would mean existing configs ppl have wouldn't work.
The text was updated successfully, but these errors were encountered: