Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate switching to Configured for Fabric mod config menu #303

Open
squeek502 opened this issue May 16, 2024 · 0 comments
Open

Investigate switching to Configured for Fabric mod config menu #303

squeek502 opened this issue May 16, 2024 · 0 comments

Comments

@squeek502
Copy link
Owner

squeek502 commented May 16, 2024

Currently the Fabric version of AppleSkin uses autoconfig + clothconfig for its config file and mod menu config screen integration. This works fine, but it means that AppleSkin includes a copy of Cloth as a jar-in-jar, which accounts for most of the size of the AppleSkin jar (1.1MiB jar with cloth, 76.7KiB without it).

Configured, instead, works more like ModMenu, where it automatically generates mod config screens for supported configs and is installed separately. For the NeoForge/Forge versions of AppleSkin, Configured works out-of-the-box.

However, to use Configured on Fabric, AFAICT AppleSkin would need to either:

  • Use a supported config system; it lists Framework or JEI
    • Not a fan of this option, as it'd mean taking on a (different) dependency that we'd likely have to include in the AppleSkin jar
  • Use the Configured API to provide config information
    • This should mean that we only need to build against the Configured API with no runtime dependency

Just something to consider.

Other notes:

  • Would also want to make sure any existing config files can be transferred over to the new system transparently
  • Would want to make sure the localizations can be used with Configured
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant