Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration GUI is broken #85

Closed
James-E-A opened this issue Dec 29, 2020 · 6 comments
Closed

Configuration GUI is broken #85

James-E-A opened this issue Dec 29, 2020 · 6 comments
Labels
forge upstream Specific to something that this mod relies on

Comments

@James-E-A
Copy link

The Configuration button is greyed-out and non-functional:

Screenshot from 2020-12-28 18-23-51

This is on

  • Minecraft 1.16.4
  • Forge 35.1.4
  • AppleSkin 1.0.14

(Yes, I know the screenshot already has those, but I'm including them for indexing if this issue is searched later)
@GirafiStudios
Copy link
Collaborator

Forge removed the config GUI in 1.13, so it's currently not possible for mods to do anything with that button.

@James-E-A
Copy link
Author

Ah, you're right

This issue depends on MinecraftForge/MinecraftForge#7395

@James-E-A James-E-A mentioned this issue Dec 29, 2020
Closed
@James-E-A
Copy link
Author

James-E-A commented Jan 19, 2021 •
edited
Loading

  1. For Forge, could this be re-opened with the forge and upstream labels?

  2. For Fabric, it looks like the ModMenu API is actively maintained and provides a classic UX

(I took the below screenshots)

Screenshot from 2021-01-18 17-14-21

Screenshot from 2021-01-18 17-13-35

Screenshot from 2021-01-18 17-14-58

@squeek502 squeek502 added enhancement fabric forge upstream Specific to something that this mod relies on labels Jan 19, 2021
@squeek502 squeek502 reopened this Jan 19, 2021
@squeek502 squeek502 mentioned this issue Jan 20, 2021
Closed
@squeek502
Copy link
Owner

Looks like the Forge PR got rejected: MinecraftForge/MinecraftForge#7395 (comment)

I don't keep up with the Forge ecosystem so if a 'standard' library for this gains consensus in the future please add a link to it here.

@GirafiStudios
Copy link
Collaborator

PR for config GUI in Forge is in the works MinecraftForge/MinecraftForge#8874

@squeek502
Copy link
Owner

I'm going to close this and suggest using Configured for the NeoForge/Forge versions of AppleSkin. From my (limited) testing, AppleSkin integrates just fine with it.

Related follow-up for Fabric: #303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forge upstream Specific to something that this mod relies on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@squeek502 @James-E-A @GirafiStudios