Fix issue with poorly implemented modded consumables returning null as foodcomponents

[NerjalNosk]

Prevents client crash upon trying to get how to render a modded consumable's details when its getFoodComponent method returns null.
Includes modification for versions from 1.19 to 1.19.4 + version bump (done via cherry-picking commits)

[squeek502]

Could you provide information about how this can be reproduced? As far as I can tell, this should be impossible since isFood() is a foodComponent != null check and both HUDOverlayHandler and TooltipOverlayHandler call isFood() before getting either of the food values.

Is some mod overriding isFood and then returning null from getFoodComponent? If so, I don't see how this wouldn't cause crashes in vanilla Minecraft code since there's many places that do things like this:

        if (stack.getItem().isFood()) {
            return this.getFoodComponent().isSnack() ? 16 : 32;
        }

[NerjalNosk]

Too be honest, I don't really know the details of the mod causing this, I only faced the bug itself.
I can give some logs tho

crash-2023-05-03_23.40.21-client.txt

[NerjalNosk]

As for how the bug really happened, I cannot tell really, for the game only crashed spontaneously about anytime I was opening any form of inventory

[SAGESSE-CN]

I suggest returning foodvalues.zero instead of null when it is null, and returning null causes all code(appleskin and user code of events) to add unknown branches

[NerjalNosk]

That might be a good idea indeed, that's something I was not aware of.
Gotta make it a thing right away

[squeek502]

Until I understand more about what's going on, it's hard to know if this is the right fix (or if this is something that AppleSkin should try to protect against, or if it's a bug in some other mod).

My suggestion would be to do something like this locally in getDefaultFoodValues:

		if (itemFood == null) {
			throw new RuntimeException("food with null FoodComponent: " + itemStack)
		}

and then reproduce the crash with that code. The crash should then let you know which ItemStack is causing the problem and we can go from there.

[NerjalNosk]

From my understanding of the actual situation, that issue is something that might have already occurred with Forge as well, for there are these checks in the forge code (in squeek.appleskin.helpers.FoodHelper#getDefaultFoodValues, L38~39)

		int hunger = itemFood != null ? itemFood.getNutrition() : 0;
		float saturationModifier = itemFood != null ? itemFood.getSaturationModifier() : 0;

Which only makes me think that this was an attempt to prevent that same error to happen, although with a set of ternary operators rather than the option I went for in the end, after @SAGESSE-CN 's suggestion

[squeek502]

I'm convinced that this is a fine change. Could you remove the version bump from this PR, though?

Out of curiosity, it might be worth tracking down the cause anyway. Here's a build of appleskin-fabric-mc1.19-2.4.1 with the RuntimeException from my previous comment included if you'd like to use it and reproduce the crash with it:

https://www.ryanliptak.com/misc/appleskin-fabric-mc1.19-2.4.1+issue235.jar

[NerjalNosk]

Oh, sorry, I did that version change mostly to avoid getting confused between the builds. I can do that right away ofc

[squeek502]

Thanks! Ended up just going with the same implementation as the Forge branch.

[NerjalNosk]

Fair enough