Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 24w14potato #293

Merged

Conversation

EnderKill98
Copy link

Since I was porting some mods I can't live without, I thought it would be cool to have this as well.

The mod is not free of errors. I noticed this render artifact:

grafik

The hunerbar has also some transparency issue when indicating newly added food when holding an item and not fully fed:

grafik

Also, while I updated the CustomPayload to the new architecture, it could not test it yet (thought it starts which is already a good indicator).

This might be a useful stepping stone. Just verify that the server plugin integration works, fix the 2 render artifacts, and it should probably be 90% done for 1.20.5 as fabric calls the version "1.20.5-alpha.24.12.potato" in the fabric.mod.json.

I didn't test or try to port Forge. Only Fabric.

@squeek502
Copy link
Owner

squeek502 commented Apr 2, 2024

Thanks!

Note that the 1.20.1-fabric branch is not the latest 1.20.x Fabric branch, though--1.20-fabric is (sorry for the confusion). So, you might want to try starting from the 1.20-fabric branch instead since some of these changes might have already been taken care of.

@EnderKill98
Copy link
Author

EnderKill98 commented Apr 2, 2024

Yeah I just noticed that. I thought some weird transparency issue was the cause for the black boxes, but the texture pointed to something like minecraft/textures/gui/icons.png instead of appleskin/textures/icons.png where they were.

Then the offsets were all wrong though, which is when I double checked and noticed the issue.

I force-pushed the branch, which is now based on 1.20-fabric, as you mentioned. Rendering seems to work fine now.

Edit:

since some of these changes might have already been taken care of

Yeah, the check for F3 and one mixin signature were already fixed. The custom payload stuff did change a lot though. I used one of minecrafts own Payloads as a guide. Fingers crossed, it just works 🤞 .

@EnderKill98
Copy link
Author

Fun fact: You can't eat him, but he is still nutritious 🤣

grafik

@EnderKill98 EnderKill98 changed the base branch from 1.20.1-fabric to 1.20-fabric April 2, 2024 20:02
Turns out that the payloads need to be registered server-side now for the server to be able to encode the packet.

Some other changes made:
- Made the Identifier for the exhaustion/saturation payloads match the latest Neoforge version
- `class` -> `record`
- A few style changes
@squeek502 squeek502 changed the base branch from 1.20-fabric to 24w14potato-fabric April 5, 2024 20:26
@squeek502
Copy link
Owner

Great work on this! It turns out that the packets need to be registered server-side to avoid packet encoding failure when sending a sync packet from the server to the client, but other than that everything looks good.

Thanks!

@squeek502 squeek502 merged commit c0530dc into squeek502:24w14potato-fabric Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants