Remaining things for 1.10 port

[elifoster]

Because my memory isn't good enough to just remember. I just went through the readme.

TODO

• Bioplastic
• Burlap
• Composting
  • Composter
  • Rotten Plants
  • Compost: Hard to tell whether it actually increases the growth rate. @squeek502 how did you initially test this?
  • Fertilizer
• Doll's Eye: Double check mining drop
• Egg Replacers: Issue: Apple Sauce and Starch not used in recipes
  • Apple Suace
  • Starch
    • Piston crafting
• Raw Ender: Issue: No texture in WAILA tip
• Faux Feather: Issue: Faux Feather not used in recipes
• Fossils: Double check mining drop
• Frozen Bubble
• Saltpeter: Double check mining drop
• Sulfur: Double check mining drop
• Vegetable Oil Ink
• Jute: Double check mining drop
• Kapok: Double check mining drop
• Blank Mob Head
• Plant Milk
• Proof of Suffering: Issue: Double check mining drop
• Resin: Issue: Double check mining drop
• Soap
• Straw Bed
• False Morel: Issues: Double check mining drop, items not used in recipes
• Vegetable Oil: Issue: Double check mining drop
• Seitan
• JEI integration
  • Fix fluid blocks crafting/usage descriptions not showing up properly (see 160e12b)
• Bioplastic as a TiCo tool material
• Frozen Bubbles in Fluid Transposer for Thermal Expansion
• Potato Starch made in Pulverizer for Thermal Expansion
• WAILA
• BBQ Sauce and BBQ Tofu
• Fluid container registry deprecated, need to convert to new system
  • Misc usage
  • Bucket stuff
  • Glass bottle stuff
  • Ender usage

Issues found

• MissingVariantException for washableWheat#inventory
• MissingVariantException for enderRift#inventory
• FileNotFoundException enderRift.json
• MissingVariantException for enderRift#normal

Untested:

• Things that have "double check mining drop" as their note
• All integration (including BBQ)

[squeek502]

Thank you for making this list. 👍

[elifoster]

@squeek502 For the JEI descriptions, should we migrate to the system already added by JEI, or should we reimplement it using the old code from the NEI TextHandler class? Using the JEI system would be significantly less code, and would have less room for error since so many people are already using it, but the text processing is significantly less powerful. Basically all formatting stuff would have to be rewritten. For example, from the lang file

example.string=Nested string example
item.VeganOption.exampleItem.name=Example
item.VeganOption.exampleItem.nei.usage=%1$s is nothing like [[minecraft:wheat]] or [[minecraft:golden_apple:1]], but it can do a {example.string}.\n\nLines broken.

would be

item.VeganOption.exampleItem.nei.usage=Example is nothing like Wheat or Golden Apple, but it can do a Nested string example.\n\nLines broken.

Either way, it the valid items would be determined by doing

		for (Item item : Item.REGISTRY)
		{
			if (item.getRegistryName().getResourceDomain().equals(ModInfo.MODID_LOWER))
			{
				if (item.getHasSubtypes())
				{
					List<ItemStack> subItems = new ArrayList<ItemStack>();
					item.getSubItems(item, null, subItems);
					for (ItemStack subItem : subItems)
					{
						String descKey = subItem.getUnlocalizedName() + ".nei.usage";
						if (LangHelper.existsRaw(descKey))
							// Register the itemstack somehow depending on the approach taken
					}
				}
				else
				{
					ItemStack toAdd = new ItemStack(item);
					String descKey = toAdd.getUnlocalizedName() + ".nei.usage";
					if (LangHelper.existsRaw(descKey))
						// Register the itemstack somehow depending on the approach taken
				}
			}
		}

I've done it both ways and that code works well.

[squeek502]

@elifoster see 160e12b

[elifoster]

I provided a review. 👍ing the stuff you agree with would be appreciative—I can work on the stuff I brought up no problem.

As for the fluid thing, I'm not sure I quite understand the problem. What is wrong with it being looked up using FluidStacks?

[squeek502]

Replied to your comments, will commit something that addresses them in a bit. EDIT: 1470604

As for the fluid thing, I'm not sure I quite understand the problem. What is wrong with it being looked up using FluidStacks?

The issue is currently that if you press R or U on any of the fluid blocks in JEI (Raw Ender, for example), nothing comes up. Raw Ender should have a Crafting description that shows up, saying that it's the byproduct of an Ender Rift (note: if you do usage of Ender Rift, Raw Ender shows up as a byproduct, so it's not a symmetrical bug).

EDIT: Fixed by 036f5ab

[elifoster]

Regarding "Make fluid containers and fluids have the same recipes/usages," it might be better to simply use the fluid containers for the recipes/usages, and then to blacklist the fluid blocks from showing up at all in JEI. What do you think?

[squeek502]

it might be better to simply use the fluid containers for the recipes/usages, and then to blacklist the fluid blocks from showing up at all in JEI

This is complicated by the fact that certain things will output/use contained fluids, and certain things will output/use fluid blocks from the world. So, if everything shows up as a contained fluid, that divide will be confusing (for example, piston crafting showing input/output of bottled fluid, when that is not how it works).

It might be possible to get around this, though, by making what shows up in JEI independent of what gets set as the input/output in the Wrapper implementations (e.g. IRecipeWrapper.getIngredients sets the bottled fluid as the input, but the category implementation sets the slot to the fluid block--this is kind of what 036f5ab did). I'll look into this more and see what's possible.

[squeek502]

Putting this here (copied from IRC) just so I don't forget about it:

<squeek> @SatanicSanta, looks like there's still some stuff left that needs to be done with fluid containers
<squeek> VO's bottles/buckets dont interact with the basin anymore
<squeek> prob need to either update bottles to the capacity system or put backwards compatibility in the basin code
<squeek> or both

---

Also, with the description stuff working properly, the "Make fluid containers and fluids have the same recipes/usages" thing is not as important, since I believe all bottled fluids link to their fluid blocks with the byproducts/byproduct of sections. I think we should focus on the few remaining things and hold off on this bit (will make a separate issue for it and remove it from this checklist).

[squeek502]

Maybe spoke too soon about closing this. Going to re-open and use it to track a few remaining things:

• Raw Ender buckets don't create full fluid blocks when the fluid is placed in the world
• Frozen Bubbles don't get filled properly from Raw Ender in the world (a full bucket of Raw Ender only fills a bubble 1/8 of the way)
• Stacks of empty containers don't work when right clicked on a basin they could be filled from, and multiple empty containers as an EntityItem don't get filled if they are inside a basin they could be filled from
• Stacks of filled containers don't get consumed properly when used to fill something like a basin (the stack size doesn't change)