Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight texture issues on tooltip #1

Closed
mezz opened this issue Aug 13, 2016 · 3 comments
Closed

Slight texture issues on tooltip #1

mezz opened this issue Aug 13, 2016 · 3 comments
Labels

Comments

@mezz
Copy link

mezz commented Aug 13, 2016

Hovering over a food item, starting from the left and moving 1px right each screenshot:
On the third screenshot you can see some pink lines to the left of each saturation icon.

2016-08-13_15 05 39
2016-08-13_15 05 41
2016-08-13_15 05 43
2016-08-13_15 05 45

@squeek502
Copy link
Owner

This is something that popped up in 1.7.2 (the same code in 1.6.4 didn't have this issue) and I've never been able to figure out why it happens, although I haven't looked too deeply.

It seems to be related to drawing scaled icons. Relevant code:

https://github.com/squeek502/AppleSkin/blob/1.10.2/java/squeek/appleskin/client/TooltipOverlayHandler.java#L136-L162

@squeek502 squeek502 added the bug label Aug 13, 2016
@mezz
Copy link
Author

mezz commented Aug 13, 2016

I had a similar issue with scaled icons on the Forestry Beealyzer. I solved it by... not scaling icons. :(
My best guess is it's a UV issue, where the scaled icons UVs do not exactly hit the right icon in the texture map due to extremely tiny float rounding errors.
Maybe you could make a mini version of the saturation icon to use?

@squeek502
Copy link
Owner

Took your suggestion and added smaller versions of the icons. Fixed in v1.0.1: https://github.com/squeek502/AppleSkin/releases/tag/v1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants