Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producer generates incorrect timezone (double shift) #16

Closed
Spudz76 opened this issue Sep 7, 2014 · 1 comment
Closed

Producer generates incorrect timezone (double shift) #16

Spudz76 opened this issue Sep 7, 2014 · 1 comment

Comments

@Spudz76
Copy link

Spudz76 commented Sep 7, 2014

A: https://github.com/squeeks/glossy/blob/master/lib/glossy/produce.js#L358
This loop adjusts the time string based on the incoming Date object timezone... to make the time UTC

B: https://github.com/squeeks/glossy/blob/master/lib/glossy/produce.js#L363
Then this logic translates the original Date object timezone to append to the already adjusted time string.

So, this needs to either A or B but not both. Probably should just roll on through with timeOffset as 'Z'... Everyone loves UTC on the wire and it already does a nice job pre-shifting.

Spudz76 added a commit to Spudz76/glossy that referenced this issue Sep 7, 2014
@Spudz76
Copy link
Author

Spudz76 commented Sep 7, 2014

Fixed in PR #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant