Fix RFC 3339 date offset handling #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UTC dates were being used but a time offset was being calculated. Either a time offset of UTC should be used or the date and time should take the offset into account. I chose to implement the former option.
rcrichton
added a commit
to jembi/openhim-mediator-RFC3881toDICOM
that referenced
this pull request
Dec 14, 2015
The official version of glossy doesn't handle date offsset properly when producing syslog messages. There is a PR open, but for now we can use the fork. Here is the PR: squeeks/glossy#33
|
@squeeks how does this look to you? Anything I'm missing? |
|
Sorry, but I think this should go the other way - although "UTC all the things" is a poor assumption when there are human (not machine) reasons for wanting to provide timestamps in a particular TZ. Also, it's worth noting that the tests are run as CET because node.js's own tests were, once upon a time. |
Closed
rcrichton
added a commit
to rcrichton/glossy
that referenced
this pull request
Dec 17, 2015
Glossy was mixing a time offset with UTC dates when producing syslog messages. This change fixes this so that time offsets are used properly. Original discussion around this can be found here: squeeks#33
squeeks
pushed a commit
that referenced
this pull request
Dec 24, 2016
Glossy was mixing a time offset with UTC dates when producing syslog messages. This change fixes this so that time offsets are used properly. Original discussion around this can be found here: #33
mikehu
pushed a commit
to logdna/glossy
that referenced
this pull request
Jan 11, 2017
Glossy was mixing a time offset with UTC dates when producing syslog messages. This change fixes this so that time offsets are used properly. Original discussion around this can be found here: squeeks#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTC date and time components were being used but a time offset was also being calculated. Either a time offset of UTC should be used or the date and time should take the offset into account. I chose to implement the former option as it is easier, however, it could go either way.