Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id3 0.80 can't find file with brackets in name #7

Closed
WonderRat opened this issue Mar 8, 2016 · 7 comments
Closed

id3 0.80 can't find file with brackets in name #7

WonderRat opened this issue Mar 8, 2016 · 7 comments
Assignees

Comments

@WonderRat
Copy link

E:\>for %m in (*.mp3) do id3 -v "%m"

E:\>id3 -v "[test].mp3"
id3: no files matching [test].mp3

E:\>id3 -v "[].mp3"
id3: no files matching [].mp3
@squell
Copy link
Owner

squell commented Mar 8, 2016

Thanks. Introduced in commit 56f6ef4.

Out of curiousity: if a directory contains both 't.mp3' and '[test].mp3', which file do you think the wildcard '[test].mp3' should match? (bash selects "t.mp3"; Take Command selects "[test].mp3".)

@squell squell self-assigned this Mar 8, 2016
@squell squell added the bug label Mar 8, 2016
@WonderRat
Copy link
Author

If you want to support such wildcards, then t.mp3 and need an option to disable wildcards.

@DmitriK
Copy link

DmitriK commented Apr 23, 2017

+1. I'm using GNU parallel to invoke id3 which calls it with one file at a time. The internal pattern matching is making it impossible to modify files with brackets in them. I agree that there needs to be a way of ignoring wildcards and treating the filename as verbatim.

@squell squell added enhancement and removed bug labels Apr 30, 2017
@squell
Copy link
Owner

squell commented Apr 30, 2017

  1. Fixed the bug which made id3 ignore files with brackets in them (which was introduced in 56f6ef4).
  2. Added the -X / --no-glob option which disables wildcard handling altogether

Both changes are now in master: 53c538f...d257053

Thanks for the bug reports and helpful comments!

@squell
Copy link
Owner

squell commented Jun 14, 2017

My fix is incomplete, as --no-glob is ignored for a simple id3 / id3 -v. I should probably also add escaping to allow globbing to be used in combination with files which have brackets in them.

@squell squell reopened this Jun 14, 2017
@squell squell added the bug label Jun 14, 2017
@hejops
Copy link

hejops commented Mar 14, 2021

Has any progress been made on this bug?

@squell
Copy link
Owner

squell commented Jan 12, 2024

  • --no-glob should also affect id3 -v or plain id3
  • \ can be used to escape [, ? and *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants