Better handling of data types of custom compression parameters. Fixes #…

…136
squid-box · Aug 15, 2021 · 6153867 · 6153867
1 parent a864e93
commit 6153867
Showing 1 changed file with 3 additions and 21 deletions.
diff --git a/SevenZip/SevenZipCompressor.cs b/SevenZip/SevenZipCompressor.cs
@@ -338,37 +338,19 @@ private void SetCompressionProperties()
 
                     foreach (var pair in CustomParameters)
                     {
-#region Validate parameters against compression method.
+                        #region Validate parameters against compression method.
 
                         if (_compressionMethod != CompressionMethod.Ppmd && (pair.Key.Equals("mem") || pair.Key.Equals("o")))
                         {
                             ThrowException(null, new CompressionFailedException($"Parameter \"{pair.Key}\" is only valid with the PPMd compression method."));
                         }
 
-#endregion
+                        #endregion
 
                         names.Add(Marshal.StringToBSTR(pair.Key));
                         var pv = new PropVariant();
 
-#region List of parameters to cast as integers
-
-                        var integerParameters = new HashSet<string>
-                        {
-                            "fb",
-                            "pass",
-                            "o",
-                            "yx",
-                            "a",
-                            "mc",
-                            "lc",
-                            "lp",
-                            "pb",
-                            "cp"
-                        };
-
-#endregion
-
-                        if (integerParameters.Contains(pair.Key))
+                        if (pair.Value.All(char.IsDigit))
                         {
                             pv.VarType = VarEnum.VT_UI4;
                             pv.UInt32Value = Convert.ToUInt32(pair.Value, CultureInfo.InvariantCulture);