Added a TODO about possibly unreachable code

squid-cache · Jul 22, 2019 · 53a8826 · yadij · Jul 22, 2019 · 53a8826
1 parent 854c634
commit 53a8826
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/client_side.cc b/src/client_side.cc
@@ -387,6 +387,9 @@ ClientHttpRequest::logRequest()
         al->http.code = al->reply->sline.status();
         al->http.content_type = al->reply->content_type.termedBuf();
     } else if (loggingEntry() && loggingEntry()->mem_obj) {
+        // possibly unreachable code, since al->reply is always
+        // initialized before loggingEntry and TODO: if al->reply
+        // is nil, loggingEntry is nil either.`
         al->http.code = loggingEntry()->mem_obj->getReply()->sline.status();
         al->http.content_type = loggingEntry()->mem_obj->getReply()->content_type.termedBuf();
     }