Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 4528: ICAP transactions quit on async DNS lookups (#795)
The bug directly affected some ICAP OPTIONS transactions and indirectly affected some ICAP REQMOD/RESPMOD transactions: * OPTIONS: When a transaction needed to look up an IP address of the ICAP service, and that address was not cached by Squid, it ended prematurely because Adaptation::Icap::Xaction::doneAll() was unaware of ipcache_nbgethostbyname()'s async nature. This bug is fixed now. * REQMOD/RESPMOD: Adaptation::Icap::ModXact masked the _direct_ effects of the bug: ModXact::startWriting() sets state.writing before calling openConnection() which schedules the DNS lookup. That "I am still writing" state makes ModXact::doneAll() false while a REQMOD or RESPMOD transaction waits for the DNS lookup. However, REQMOD and RESPMOD transactions that require an OPTIONS transaction (because the service options have never been fetched before or have expired) could still fail because the OPTIONS transaction they trigger could fail as described in the first bullet. For example, the first few REQMOD and RESPMOD transactions for a given service -- all those started before the DNS lookup completes and Squid caches its result -- could fail this way. With the OPTIONS now fixed, these REQMOD and RESPMOD transactions should work correctly. Broken since inception (commit fb505fa).
- Loading branch information