RFC 7230 forbids generation of userinfo subcomponent of https URL (#405)

squid-cache · Jun 12, 2019 · e1e861e · e1e861e
1 parent 3532355
commit e1e861e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/anyp/Uri.cc b/src/anyp/Uri.cc
@@ -496,7 +496,7 @@ AnyP::Uri::absolute() const
         if (getScheme() != AnyP::PROTO_URN) {
             absolute_.append("//", 2);
             const bool omitUserInfo = getScheme() == AnyP::PROTO_HTTP ||
-                                      getScheme() != AnyP::PROTO_HTTPS ||
+                                      getScheme() == AnyP::PROTO_HTTPS ||
                                       userInfo().isEmpty();
             if (!omitUserInfo) {
                 absolute_.append(userInfo());