Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of Gopher responses #1022

Closed
wants to merge 1 commit into from
Closed

Improve handling of Gopher responses #1022

wants to merge 1 commit into from

Conversation

MegaManSec
Copy link
Contributor

No description provided.

@squid-prbot
Copy link
Collaborator

Can one of the admins verify this patch?

@kinkie
Copy link
Contributor

kinkie commented Apr 17, 2022

ok to test

@yadij yadij added the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Apr 17, 2022
@yadij yadij requested a review from rousskov April 17, 2022 22:59
@yadij
Copy link
Contributor

yadij commented Apr 17, 2022

@rousskov requesting your review for fasttrack. I know you have already reviewed this elsewhere.

@yadij yadij added the S-waiting-for-more-reviewers needs a reviewer and/or a second opinion label Apr 17, 2022
kinkie
kinkie approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@kinkie kinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not @rousskov but looks good enough to me :)

@rousskov rousskov changed the title Improve handling of Gopher responses. Improve handling of Gopher responses Apr 18, 2022
@rousskov rousskov removed the S-waiting-for-more-reviewers needs a reviewer and/or a second opinion label Apr 18, 2022
@rousskov rousskov removed their request for review April 18, 2022 13:30
@rousskov
Copy link
Contributor

I removed the period from the PR title. The PR is on the fast track to be merged soon.

@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Apr 19, 2022
squid-anubis pushed a commit that referenced this pull request Apr 19, 2022
@MegaManSec @squid-anubis
Improve handling of Gopher responses (#1022)
5e2ea2b
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Apr 19, 2022
squidadm pushed a commit to squidadm/squid that referenced this pull request May 9, 2022
@MegaManSec @squidadm
Improve handling of Gopher responses (squid-cache#1022)
54fdc0d
yadij pushed a commit that referenced this pull request May 10, 2022
@MegaManSec @yadij
Improve handling of Gopher responses (#1022)
1740315
squidadm pushed a commit to squidadm/squid that referenced this pull request Jun 17, 2022
@MegaManSec @squidadm
Improve handling of Gopher responses (squid-cache#1022)
40c56ff
squidadm pushed a commit to squidadm/squid that referenced this pull request Jun 17, 2022
@MegaManSec @squidadm
Improve handling of Gopher responses (squid-cache#1022)
ade94d6
yadij pushed a commit that referenced this pull request Jun 18, 2022
@MegaManSec @yadij
Improve handling of Gopher responses (#1022)
780c4ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinkie kinkie kinkie approved these changes

@yadij yadij yadij approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
6 participants
@MegaManSec @squid-prbot @kinkie @yadij @rousskov @squid-anubis