Bug 5232: Fix GCC v12 build [-Wuse-after-free] #1136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch should fix the gcc-12 build problem, but it is not still clear why it made gcc-12 happy. We need some more time to figure out what the underlying problem is and whether this solution is the correct one (or come up with another solution). |
yadij
approved these changes
Sep 9, 2022
|
IMO commit this to fix the immediate build. RefCount has a number of issues identified long ago by static analysis, and this may just be a side effect of those that the newest GCC are more picky about. |
|
Since there is no emergency here (AFAICT), I support spending a bit more time on trying to figure out what is really going on, now that we have a much easier-to-reproduce case than the Coverity ones.
|
|
@eduard-bagdasaryan, thanks a lot for researching this problem! I have updated PR description to reflect your findings. Please adjust as needed. Once the PR description is agreed upon, we should merge this PR. |
rousskov
approved these changes
Sep 14, 2022
squid-anubis
pushed a commit
that referenced
this pull request
Sep 14, 2022
This warning is a false positive. Introduced in GCC v12, use-after-free checks have attracted dozens of bug reports, with several reports still open as of GCC v12.2, including one that looks very similar to our case: https://gcc.gnu.org/bugzilla//show_bug.cgi?id=106776 Removing (excessive) "inline" works around this GCC bug. We do not have a better workaround right now. If we see more false positives like this, we may disable -Wuser-after-free until its support matures.
squid-anubis
added
the
M-waiting-staging-checks
|
The PR description looks correct now. |
rousskov
added
the
S-waiting-for-committer
|
Thank you. I will give Amos a few days to review the updated PR description before clearing this PR for merging. @yadij , please feel free to clear at any time. |
squid-anubis
pushed a commit
that referenced
this pull request
Sep 14, 2022
This warning is a false positive. Introduced in GCC v12, use-after-free checks have attracted dozens of bug reports, with several reports still open as of GCC v12.2, including one that looks very similar to our case: https://gcc.gnu.org/bugzilla//show_bug.cgi?id=106776 Removing (excessive) "inline" works around this GCC bug. We do not have a better workaround right now. If we see more false positives like this, we may disable -Wuse-after-free until its support matures.
squid-anubis
added
M-passed-staging-checks
yadij
added
M-cleared-for-merge
squid-anubis
added
M-merged
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Dec 28, 2022
This warning is a false positive. Introduced in GCC v12, use-after-free checks have attracted dozens of bug reports, with several reports still open as of GCC v12.2, including one that looks very similar to our case: https://gcc.gnu.org/bugzilla//show_bug.cgi?id=106776 Removing (excessive) "inline" works around this GCC bug. We do not have a better workaround right now. If we see more false positives like this, we may disable -Wuse-after-free until its support matures.
kinkie
pushed a commit
to kinkie/squid
that referenced
this pull request
Jul 2, 2023
This warning is a false positive. Introduced in GCC v12, use-after-free checks have attracted dozens of bug reports, with several reports still open as of GCC v12.2, including one that looks very similar to our case: https://gcc.gnu.org/bugzilla//show_bug.cgi?id=106776 Removing (excessive) "inline" works around this GCC bug. We do not have a better workaround right now. If we see more false positives like this, we may disable -Wuse-after-free until its support matures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning is a false positive. Introduced in GCC v12, use-after-free
checks have attracted dozens of bug reports, with several reports still
open as of GCC v12.2, including one that looks very similar to our case:
https://gcc.gnu.org/bugzilla//show_bug.cgi?id=106776
Removing (excessive) "inline" works around this GCC bug. We do not have
a better workaround right now. If we see more false positives like this,
we may disable -Wuse-after-free until its support matures.