Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with clang v15.0.6 [-Wdeprecated-non-prototype] #1246

Closed
wants to merge 4 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Jan 25, 2023

clang v15.0.6 distributed with Fedora Rawhide complains about function
definitions using K&R style:

lib/snmplib/mib.c:229:1: error: a function definition without a
prototype is deprecated in all versions of C and is not supported in
C2x [-Werror,-Wdeprecated-non-prototype]

@squid-anubis squid-anubis added the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Jan 25, 2023
@rousskov rousskov changed the title snmplib: update k&r-style function definitions Fix build with clang v15.0.6 [-Wdeprecated-non-prototype] Jan 25, 2023
@squid-anubis squid-anubis removed the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Jan 25, 2023
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

I polished PR title, primarily to highlight that this is a build-fixing change. I also polished PR description, primarily to fix its formatting. Please review and adjust further as needed.

lib/snmplib/mib.c Show resolved Hide resolved
lib/snmplib/mib.c Outdated Show resolved Hide resolved
lib/snmplib/mib.c Outdated Show resolved Hide resolved
lib/snmplib/snmp_api.c Outdated Show resolved Hide resolved
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
@kinkie
Copy link
Contributor Author

kinkie commented Jan 25, 2023

Works for me. Thanks for the fast response

@rousskov rousskov added the M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels label Jan 25, 2023
squid-anubis pushed a commit that referenced this pull request Jan 27, 2023
clang v15.0.6 distributed with Fedora Rawhide complains about function
definitions using K&R style:

    lib/snmplib/mib.c:229:1: error: a function definition without a
    prototype is deprecated in all versions of C and is not supported in
    C2x [-Werror,-Wdeprecated-non-prototype]
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jan 27, 2023
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 27, 2023
squidadm pushed a commit to squidadm/squid that referenced this pull request Feb 23, 2023
…e#1246)

clang v15.0.6 distributed with Fedora Rawhide complains about function
definitions using K&R style:

    lib/snmplib/mib.c:229:1: error: a function definition without a
    prototype is deprecated in all versions of C and is not supported in
    C2x [-Werror,-Wdeprecated-non-prototype]
yadij pushed a commit that referenced this pull request Feb 23, 2023
clang v15.0.6 distributed with Fedora Rawhide complains about function
definitions using K&R style:

    lib/snmplib/mib.c:229:1: error: a function definition without a
    prototype is deprecated in all versions of C and is not supported in
    C2x [-Werror,-Wdeprecated-non-prototype]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
3 participants