New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with clang v15.0.6 [-Wdeprecated-non-prototype] #1246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squid-anubis
added
the
M-failed-description
https://github.com/measurement-factory/anubis#pull-request-labels
label
Jan 25, 2023
rousskov
changed the title
snmplib: update k&r-style function definitions
Fix build with clang v15.0.6 [-Wdeprecated-non-prototype]
Jan 25, 2023
squid-anubis
removed
the
M-failed-description
https://github.com/measurement-factory/anubis#pull-request-labels
label
Jan 25, 2023
rousskov
reviewed
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this.
I polished PR title, primarily to highlight that this is a build-fixing change. I also polished PR description, primarily to fix its formatting. Please review and adjust further as needed.
Co-authored-by: Alex Rousskov <rousskov@measurement-factory.com>
Works for me. Thanks for the fast response |
rousskov
approved these changes
Jan 25, 2023
rousskov
added
the
M-cleared-for-merge
https://github.com/measurement-factory/anubis#pull-request-labels
label
Jan 25, 2023
squid-anubis
pushed a commit
that referenced
this pull request
Jan 27, 2023
clang v15.0.6 distributed with Fedora Rawhide complains about function definitions using K&R style: lib/snmplib/mib.c:229:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
squid-anubis
added
the
M-waiting-staging-checks
https://github.com/measurement-factory/anubis#pull-request-labels
label
Jan 27, 2023
squid-anubis
added
M-merged
https://github.com/measurement-factory/anubis#pull-request-labels
and removed
M-waiting-staging-checks
https://github.com/measurement-factory/anubis#pull-request-labels
M-cleared-for-merge
https://github.com/measurement-factory/anubis#pull-request-labels
labels
Jan 27, 2023
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 23, 2023
…e#1246) clang v15.0.6 distributed with Fedora Rawhide complains about function definitions using K&R style: lib/snmplib/mib.c:229:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
yadij
pushed a commit
that referenced
this pull request
Feb 23, 2023
clang v15.0.6 distributed with Fedora Rawhide complains about function definitions using K&R style: lib/snmplib/mib.c:229:1: error: a function definition without a prototype is deprecated in all versions of C and is not supported in C2x [-Werror,-Wdeprecated-non-prototype]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang v15.0.6 distributed with Fedora Rawhide complains about function
definitions using K&R style: