New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove OSF/1 support #942
Remove OSF/1 support #942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not clear why we are removing this code. The PR description implies that this code is removed because OSF/1 "will no longer be supported" but it is not clear whether that phrase is talking about support by OSF Project, Squid Project, or somebody else. Please rephrase to clarify that.
Assuming we are talking about support by the Squid Project here: It is not clear what "support" actually means, why we decided (or will decide) to stop supporting OSF/1, and why that means we should remove this code. As you know, we have already tried but failed to answer very similar questions about the meaning of "support" this year. IMO, we should not be using the undefined term "support" to justify code changes until we succeed.
and will no longer be supported by the time Squid-6 is released
I do not think OSF is (or should be) "supported" by the Squid Project now, so I would prefer that we do not imply otherwise in the PR description, but I do not insist on the wording change to remove that implication.
To avoid misunderstanding, I am not trying to block removal of this code. I just want us to be clear why we are removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the PR description and addressing one of my concerns. It is now clear that HP is expected to end their OSF/1 support by the time we expect Squid v6 to be released. This is good progress.
FWIW, it is still not clear why this code is being removed from Squid. Does this PR imply that the Squid Project would like to remove environment-specific code for all environments that are not longer supported by their stewards? Because "less code" is overall better? Or is there some other, perhaps more specific, motivation here?
I just want us to be clear why we are removing this code, especially since this PR can be viewed as setting precedence for other similar code removal...
And another/unrelated suggestion: If we are not sure that these code changes will make Squid unusable on OSF/1, then perhaps we can change "support" to "explicit support" in the PR title?
Withdrawing the attempt to remove this code since there seems to still be a very high bar to justify its removal. |
FTR, I support removing support for OSF/1 As a matter of supported platform, I am willing to bet that the number of platforms it makes sense for Squid to explicitly support to be limited; in order of descending relevance:
I expect the users of some of these to be already counted in the single digits worldwide; if they (and others who fell off the list) are motivated enough they can provide PRs to support their environment. Any level of code complexity to support anyone in the list is IMO not warranted |
FWIW, I also support removing OSF/1-specific code. I disagree with the unilateral decision to close this PR and with the rationale behind that decision.
I would like us to agree on a set of principles behind that (or any similar) list. You may be trying to formulate such principles after giving the list, so I will switch to that attempt without discussing any specific list entries (for now):
Given the "any" in the second half, I see a single criteria in the above statement:
I think that is a good starting point. We may want to define "user" or switch from "users" to something like "independent or uncoordinated deployments", but I am more worried about two related high-level problems:
I can propose specific solutions to these problems, but I am worried about wasting time on a yet another attempt to define "support" because there seems to be no consensus that we need to define such things and/or to carefully justify our feature removal PRs. |
The main reason for this PR is only "because we want to" - which is not worthwhile. What I wrote for description is the reasonable part of the justification for removal. If that is not enough for reviewers, then removal is not justified. Especially since this OS has a relatively modern release still under long-term vendor support. I closed because this discussion about precise wording of the description is taking up way more of our time and resources than we gain from removing any of these old OS. |
I do not know what you mean by "not worthwhile", but I think it can be a valid reason. In fact, I suspect that, with some tuning, it can become the best removal justification scheme for the Project. I will followup regarding that on squid-dev -- thank you, @kinkie, for starting that thread. |
Done in the second half of my squid-dev post. |
The last version of OSF/1 was released in 2012 under the name
Tru64 Unix for MIPS architecture CPUs. Its long-term support
by HP will be over by the time Squid-6 is released.