Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GCC v5.5.0 build after 82fe21f #962

Closed
wants to merge 2 commits into from
Closed

Fix GCC v5.5.0 build after 82fe21f #962

wants to merge 2 commits into from

Conversation

eduard-bagdasaryan
Copy link
Contributor

@eduard-bagdasaryan eduard-bagdasaryan commented Jan 11, 2022 •
edited by rousskov

Old problems revealed by recent commits:

XactionRep.cc:174:20: error: declaration of 'String name' shadows
a parameter [-Werror=shadow]

XactionRep.cc:486:33: error: declaration of 'services' shadows
a previous local [-Werror=shadow]

@eduard-bagdasaryan
Fix GCC v5.5.0 build after 82fe21f
2e41fe9 
Some recent commits (probably 82fe21f) revealed a couple
of old problems:

XactionRep.cc:174:20: error: declaration of ‘String name’ shadows
    a parameter [-Werror=shadow]

XactionRep.cc:486:33: error: declaration of ‘services’ shadows
    a previous local [-Werror=shadow]
@squid-anubis squid-anubis added the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Jan 11, 2022
@rousskov
fixup: Use a more specific parameter name
151ae2e 
This code is difficult to read because getXxRecord() does not have a
parameter to supply the sharedName. AFAICT, instead of asking for the
name, getXxRecord() uses a copy of the previously configured
masterx_shared_name, which usually(XXX) matches the masterxSharedValue()
parameter, which is the _current_ configured masterx_shared_name.

However, this PR is about the GCC warning, not other non-trivial fixes.
rousskov
rousskov approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these eCAP warnings.

@squid-anubis squid-anubis removed the M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels label Jan 11, 2022
@rousskov rousskov added the S-waiting-for-committer privileged action is expected (and usually required) label Jan 11, 2022
yadij
yadij approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@yadij yadij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, less String.

@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-committer privileged action is expected (and usually required) labels Jan 13, 2022
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jan 13, 2022
squid-anubis pushed a commit that referenced this pull request Jan 13, 2022
@eduard-bagdasaryan @squid-anubis
Fix GCC v5.5.0 build after 82fe21f (#962)
df0bc0f 
Old problems revealed by recent commits:

    XactionRep.cc:174:20: error: declaration of 'String name' shadows
    a parameter [-Werror=shadow]

    XactionRep.cc:486:33: error: declaration of 'services' shadows
    a previous local [-Werror=shadow]
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousskov rousskov rousskov approved these changes

@yadij yadij yadij approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
4 participants
@eduard-bagdasaryan @rousskov @yadij @squid-anubis