-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left nav breaks in Safari #3396
Comments
This is definitely a browser bug. Safari... the new IE. |
I think I have a fix in |
Goodness you're fast. Thanks, @squidfunk. Will test and get back to you! |
@squidfunk Actually, what's the best way to do this? Clone the insiders repository, and just update the doc structure in that clone to mirror the setup I listed in the issue description? |
OK, I cloned the insiders repo, and I adjusted the # Project information
site_name: Material for MkDocs
site_url: https://squidfunk.github.io/mkdocs-material/
site_author: Martin Donath
site_description: >-
Create a branded static site from a set of Markdown files to host the
documentation of your Open Source or commercial project
# Repository
repo_name: squidfunk/mkdocs-material
repo_url: https://github.com/squidfunk/mkdocs-material
edit_uri: ""
# Copyright
copyright: Copyright © 2016 - 2021 Martin Donath
# Configuration
theme:
name: null
custom_dir: !ENV [THEME_DIR, "material"]
# Static files
static_templates:
- 404.html
# Don't include MkDocs' JavaScript
include_search_page: false
search_index_only: true
# Default values, taken from mkdocs_theme.yml
language: en
features:
- announce.dismiss
- content.code.annotate
# - content.tabs.link
# - header.autohide
# - navigation.expand
# - navigation.indexes
# - navigation.instant
# - navigation.sections
# - navigation.tabs
# - navigation.tabs.sticky
- navigation.top
- navigation.tracking
- search.highlight
- search.share
- search.suggest
# - toc.integrate
palette:
- scheme: default
primary: indigo
accent: indigo
toggle:
icon: material/toggle-switch
name: Switch to dark mode
- scheme: slate
primary: red
accent: red
toggle:
icon: material/toggle-switch-off-outline
name: Switch to light mode
font:
text: Roboto
code: Roboto Mono
favicon: assets/favicon.png
icon:
logo: logo
# Plugins
plugins:
- search:
separator: "[\\s\\-,:!=\\[\\]()\"/]+|\\.(?!\\d)|&[lg]t;|(?!\\b)(?=[A-Z][a-z])"
- social
- redirects:
redirect_maps:
changelog/insiders.md: insiders/changelog.md
reference/meta-tags.md: reference/index.md
reference/variables.md: https://mkdocs-macros-plugin.readthedocs.io/
sponsorship.md: insiders/index.md
upgrading.md: upgrade.md
- minify:
minify_html: true
# Customization
extra:
analytics:
provider: google
property: !ENV GOOGLE_ANALYTICS_KEY
feedback:
title: Was this page helpful?
ratings:
- icon: material/emoticon-happy-outline
name: This page was helpful
data: 1
note: Thanks for your feedback!
- icon: material/emoticon-sad-outline
name: This page could be improved
data: 0
note: >-
Thanks for your feedback! Help us improve this page by
<a href="https://docs.google.com/forms/d/e/1FAIpQLSe8L5YDggZiVjgvBKfv-XCdbQAEJrseRh8MBh-jS92TU2aqzw/viewform?usp=pp_url&entry.853143515={url}" target=_blank>telling us what you're missing</a>.
social:
- icon: fontawesome/brands/github
link: https://github.com/squidfunk
- icon: fontawesome/brands/gitter
link: https://gitter.im/squidfunk/mkdocs-material
- icon: fontawesome/brands/docker
link: https://hub.docker.com/r/squidfunk/mkdocs-material/
- icon: fontawesome/brands/twitter
link: https://twitter.com/squidfunk
- icon: fontawesome/brands/linkedin
link: https://linkedin.com/in/squidfunk/
- icon: fontawesome/brands/instagram
link: https://instagram.com/squidfunk
# Extensions
markdown_extensions:
- admonition
- abbr
- attr_list
- def_list
- footnotes
- meta
- md_in_html
- toc:
permalink: true
- pymdownx.arithmatex:
generic: true
- pymdownx.betterem:
smart_enable: all
- pymdownx.caret
- pymdownx.details
- pymdownx.emoji:
emoji_index: !!python/name:materialx.emoji.twemoji
emoji_generator: !!python/name:materialx.emoji.to_svg
- pymdownx.highlight:
anchor_linenums: true
- pymdownx.inlinehilite
- pymdownx.keys
- pymdownx.magiclink:
repo_url_shorthand: true
user: squidfunk
repo: mkdocs-material
- pymdownx.mark
- pymdownx.smartsymbols
- pymdownx.superfences:
custom_fences:
- name: mermaid
class: mermaid
format: !!python/name:pymdownx.superfences.fence_code_format
- pymdownx.tabbed:
alternate_style: true
- pymdownx.tasklist:
custom_checkbox: true
- pymdownx.tilde
# Page tree
nav:
- Wildlife: wildlife.md
- Animals:
- Land:
- Land Animals: animals/land/index.md
- Sea:
- Sea Animals: animals/sea/index.md If I run mkdocs-material.mov
Let me know if there's a better way to test, happy to try again if the way I'm doing it isn't valid. Also, if I should put these things in other issues, can do that, too. |
That is weird and probably related to something else. You can install the latest version with:
If that doesn't work, try:
|
Oh, OK. I thought that'd grab the latest release tag, not the latest on |
It's not yet released, as I wanted to check if it's fixed first. On a side note: there's no possibility to install "latest release" via |
Today I learned. :) Thanks! Let me try again with this approach and see how it goes. |
@squidfunk OK, after I installed using the So, all good news. Thank you! |
Awesome, thanks for checking! |
Released as part of 8.1.4-insiders-4.5.1. |
I adjusted the code that fixes the bug to fix a regression because of this fix in #3526 – could you check the latest Insiders if the issue re-appears (i.e. regresses)? My testing shows that the bug still does not re-appear, but better save than sorry. |
Oh, definitely... thanks for the heads-up. Will give it a try and report back. |
Just did a quick test, seems fine! Will let you know if I see it pop back up. Thanks, @squidfunk. |
Perfect, thanks! New fix is even better as it doesn't push every navigation item on a new layer. |
Contribution guidelines
I've found a bug and checked that ...
mkdocs
orreadthedocs
themescustom_dir
,extra_javascript
andextra_css
Description
Expected behaviour
Left nav works as normal.
Actual behaviour
Left nav sometimes disappears and/or freezes up.
Steps to reproduce
mkdocs serve
See video, here:
mkdocs-material-safari-left-nav.mov
Package versions
Configuration
System information
The text was updated successfully, but these errors were encountered: