-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚀 Material for MkDocs 9 – Beta #4714
Comments
The Python release does not work due to a problem with our new build system, hatch. @ofek, could you please take a look? Otherwise I need to revert to Edit: nope, even installing from |
What commit made CI suddenly fail? |
As you can see here, the version determination logic failed again. Probably due to the beta version modifier. |
@squidfunk the schema (well, REGEX) that Are you able to change your |
No, there's no dash, it's just |
@squidfunk but this is used for |
Yes, it is used in |
|
Ha, all this stuff is a little bit fiddly. I'm not an expert, but I try to follow the standards where given, so that's informing my position. To add some context; I develop It might be possible to add an option to preserve the dash if we needed, but I'd prefer not to as it adds more complexity, where currently the code is quite simple (and therefore understandable).
I note that you found the |
I'm having a issue with the latest git build as instructed to use in another issue...
Trying to use a custom toc permalink character breaks... site_name: test
strict: true
theme:
name: material
markdown_extensions:
- toc:
permalink: "#"
Python 3.11.1 |
Yes that is the fix |
I see this as well, even just reverting to - toc:
permalink: true Still ends up rendering a |
Fixed in 3e9b72c! This was a search + replace error. |
I just released the latest fixes as part of 9.0.0b3. |
After upgrading to 9.0.0b3 am getting "tags" plugin not installed. Anyone noticed? |
@shanthisagar-dhanya-kumar-db I'm not seeing this problem, the built-in tags plugin works fine. Could you please try and create a minimal reproduction? You could then attach it here as a zip and I'll have a look. |
The latest commits fix highlighting of tags and improve the URL when using search sharing. Furthermore, now, the full range of Lunr.js query syntax is supported! I've reordered how the search query is preprocessed and ensured that only search terms (not modifiers) are sent through the transformation and tokenization pipeline. This lays the foundation for more interesting features to come.
When releasing the stable version, I'll expand in a blog article on the new capabilities and how it works. |
The global |
Did you re-enable the footer navigation (see OP)? The |
As mentioned in #4755, the new version fails to build the site if the feedback URL uses nameless placeholders:
Using the new format is now mandatory. |
Thanks @kcgthb, I updated the OP. |
Hello! I wanted to inquire if this could be a possible bug/issue with the new search plugin. In our production build In testing, For reference I've tested it by searching locally and on our vercel preview. A small working around is to enable I've personally tested this with a stripped-down version of our production config (no plugins, features beyond search).
Any insight if this is as intended and if utilizing Project Staging Link for the above PR. |
@Valastiri thanks for reporting. This is not a bug. Search previews might now be larger, as they are cut at paragraphs and lists, and are not truncated anymore. If truncation is wished, one can do so by using CSS (see below), but some users might not like that. More compact search summaries are an improvement that is on the roadmap and tracked in #4278. If you want the previous behavior, you can add the following additional CSS which will clamp search after 3 lines: .md-search-result .md-typeset {
display: -webkit-box;
-webkit-line-clamp: 3;
-webkit-box-orient: vertical;
} Compact search previews are very hard to support for all languages that we support in Material for MkDocs (50+ languages). However, with the new tokenization approach, they finally became possible. See the paragraph on accurate highlighting why this is hard. I will soon start working on this new feature. |
Thanks! Good to know. Appreciate the response and all the work on Material thus far :). Love the platform/theme. |
Hi @squidfunk, I'm the developer of I've read the comments in this issue and the related ones but found no clear steps to re-enable them, can you help me? Thanks for maintaining this project so well, it's awesome, both docs, quality, release process... |
Please read the original post, the one at the top. It clearly explains what to do. Excerpt:
Some users wished to disable the footer for a long time, which is why it is now opt-in.
Thanks! Trying my best to stay atop of things. This wouldn't be possible without our awesome sponsors ❤️ |
Oh sorry, I didn't understood what OP meant. That fixed the issue |
Thanks for everybody testing the beta so far! Since it's impossible to predict what will break down the line, I don't think it's a good idea to push this out before Christmas or even NYE. People are busy getting presents, and, in Germany, meeting in the evening to drink some Glühwein, so it's probably not a good idea to impose such a major change upon them right now. We'll move v9 out of beta at the beginning of next year. If you already want to try it, no problem, just install the beta (see OP) and see if you run into any problems. You can already fix them on a separate branch, and then later, when v9 is out, just remove the Final release date will be January 2, 2023. |
@facelessuser GitHub action workflow output gave me this with
|
@jrappen |
I'm not sure if related to this beta or not (I'm running 9.0.0b4) but I've found when following the instructions at https://squidfunk.github.io/mkdocs-material/reference/data-tables/#sortable-tables and added the |
I just tested Tablesort locally on the |
Thanks @squidfunk - I'm pleased to say it turns out that "me being an idiot" was actually the issue 😂 - I had lots of folders open and only just realised when going back in today that |
Thank you all for testing the beta! 9.0.0 will be released today. |
@squidfunk isn't the hero we deserve, but the one we need. ❤️ |
@squidfunk, updated from 8.5.11 to 9.0.0 and this error appears. ERROR - Error building page 'guide/start.md': list index out of range |
@highlander Possibly related: #4824. If this is not the cause, please create a separate bug report. |
With the help of our awesome sponsors, I'm happy to announce that the 'Carolina Reaper' funding goal has been reached, which means that the brand new search is finding its way into the community edition!
Since this is a pretty major change, we're releasing the new search as part of a new major version, so we can also drop and refactor some things that are overdue. This issue will track the progress on the road from the beta to the final release of v9.
If you experience any problems, for now, please report them as a comment in this issue.
Installation
Additions and improvements
--dirtyreload
Removals
:is
selectors (in output) to allow for easier overriding of CSS in daffd08.title
suffix on translations in 37250f1Fixes
kr
ko
) in 5aebaaatags:foo
ortitle:bar
)-foo
or-title:bar
)foo~1
ortitle:bar~2
)foo^2
ortitle:bar^4
)*foo
or*title:bar
)Upgrading
Changes to
mkdocs.yml
Enable copy-to-clipboard button: the copy-to-clipboard buttons are now opt-in. If you wish to enable them for all code blocks, add the following lines to
mkdocs.yml
:You can also choose to enable them for specific code blocks, by adding a
.copy
class to the code block, like so:Similarily, if you enabled the button globally, but want to disable it for a specific code block use
.no-copy
:Enable edit and view source button: a "view source" button can be shown next to the "edit this page" button, both of which must now be explicitly enabled. The
repo_url
must also be given. Add the following lines tomkdocs.yml
:Enable navigation footer: the previous and next buttons in the footer are now opt-in. If you wish to keep them for your documentation, add the following lines to
mkdocs.yml
:Use Korean language: the Korean language code was
kr
, which is not correct. It was corrected toko
:Use Norwegian languages: the Norwegian language code was
no
, was no renamed tonb
.Feedback widget URLs: the old, nameless placeholders were removed (after being deprecated for several months). If Make sure to switch to the new named placeholders
{title}
and{url}
:https://github.com/.../issues/new/?title=[Feedback]+{title}+-+{url}
There should be no other changes to
mkdocs.yml
necessary. If you discover that you need to change other lines to make v9 work, please comment below, so we can add it to the list.Changes to documents
Alternate admonition qualifiers: to keep the size of the CSS down, we removed support for alternate admonition qualifiers. Please use the standard admonition qualifiers that are mentioned in our documentation.Changes to customizations
If you've customized Material for MkDocs with theme overrides, and added your own partials, you need to adjust for some changes, as the translations keys got updated. Keys that end with
.title
have been stripped off the suffix, sofooter.title
now becomesfooter
. The reason is that those are mostly generic translations of components that may not only be used intitle
attributes. See the partial diff.Closing thoughts
Version 9 is a pretty big release, which includes a completely rewritten search implementation. I'm super happy to finally give it into the hands of all users, so we can improve it even more. Before issuing the final release, I'll take the opportunity to refactor some edges that need a little polishing and incorporate your feedback.
The text was updated successfully, but these errors were encountered: