New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Norwegian translations #4647
Conversation
Thanks for providing the updated PR. Unfortunately, not all of my qquestions were answered – does it make sense to have support for |
No, it does not make any sense. The
It is a copy of |
Ok, perfect, thanks for the explanation. Please remove |
@squidfunk done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments and our contributing guide.
src/partials/languages/nn.html
Outdated
"meta.comments": "Kommentarar", | ||
"meta.source": "Kjelde", | ||
"search.config.lang": "no", | ||
"nav.title": "Navigasjon", | ||
"search.config.lang": "nn", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the changes for search.config.*
(here and in the other translation). I'm pretty confident that with those lines present, search will not work. Lunr languages only supports no
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much appriciated feedback @squidfunk! Sorry for not reading the entire contributing guide, my bad 🙄
I notice in lunr.no.js that it mixes both languages (nn
and nb
), so I think it is best to define "search.config.lang": "no"
. Then the search will work too.
All good! I've merged your changes into the v9 branch, tracked in #4628. |
Error message using Norwegian Bokmål: However, using the code for Norwegian Bokmål, nb, does not work: This combination gives an error message and tells me the web page is unavailable. Is there a way to choos Norwegian Bokmål as the language for the page? Regards, |
No, |
Thanks, I thought I had installed the latest, but it was v.8.3.3 :-( After updating to the latest revision everything works. |
@squidfunk Agree! Removing
no
could be a breaking change, better to do it in next major release.