Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing FastClick #976

Closed
coliff opened this issue Feb 1, 2019 · 2 comments
Closed

Consider removing FastClick #976

coliff opened this issue Feb 1, 2019 · 2 comments
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open

Comments

@coliff
Copy link
Contributor

coliff commented Feb 1, 2019

From the FastClick Readme:
https://github.com/ftlabs/fastclick/blob/master/README.md

As of late 2015 most mobile browsers - notably Chrome and Safari - no longer have a 300ms touch delay, so fastclick offers no benefit on newer browsers, and risks introducing bugs into your application. Consider carefully whether you really need to use it.

I think it'd be good to remove this to keep the JS lighter.
@squidfunk squidfunk added the change request Issue requests a new feature or improvement label Feb 1, 2019
@squidfunk
Copy link
Owner

FastClick removed in 9a4b142. Will be part of the next release.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Feb 13, 2019
@squidfunk
Copy link
Owner

Released as part of 4.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change request Issue requests a new feature or improvement resolved Issue is resolved, yet unreleased if open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@squidfunk @coliff