Fetch KaTeX and MathJax from UNPKG #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind, minified version on jsDelivr is unfortunately broken. |
|
I found a way to fix this. |
|
FWIW, I tested it in deployment as well, e.g. you can see it live on this page with a formula. |
|
What's the upside? Why is jsdeliver better than Cloudflare? |
|
For me, I like that it automatically picks the latest minor version, no need to modify the config every time KaTeX puts out a new minor (or patch) release. |
|
Thanks for the explanation. I'd say we switch to unpkg then – same result: Would you like to adjust the PR? |
|
Gladly. Would you mind if I switch MathJax from jsDelivr to unpkg at the same time? |
|
We should switch everything to unpkg if possible ✌️ |
This is consistent with how we fetch Mermaid.js and automatically picks the latest minor version.
vedranmiletic
changed the title
|
Done and done. 😎 |
|
Alright, let's go! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with how we fetch Mermaid.js and automatically picks the latest minor version.