Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to control the display of the close button in the modal #41

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

dyelmag
Copy link
Contributor

@dyelmag dyelmag commented Dec 22, 2023

Summary by CodeRabbit

  • New Features
    • Introduced dynamic control over the visibility of the close button in modal dialogs through a new buttonClose property.

Copy link

coderabbitai bot commented Dec 22, 2023

Walkthrough

The update introduces a new feature that allows dynamic control over the visibility of the close button in the SqModalComponent. By adding a buttonClose input property, developers can now conditionally render the close button based on the property's value.

Changes

File Path Change Summary
.../sq-modal/sq-modal.component.html Added conditional rendering for the close button.
.../sq-modal/sq-modal.component.ts Added buttonClose input property for close button visibility control.

🐇✨
In the land of code where the bits align,
A modal's close button can now decline.
With a property's sway, it appears or hides,
As the buttonClose takes you on rides.
🌟🚪👀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples:
    • @coderabbitai render interesting statistics about this repository as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 69910e5 and 0ab76fe.
Files ignored due to filter (1)
  • src/package.json
Files selected for processing (2)
  • src/components/sq-modal/sq-modal.component.html (1 hunks)
  • src/components/sq-modal/sq-modal.component.ts (2 hunks)
Files skipped from review due to trivial changes (1)
  • src/components/sq-modal/sq-modal.component.ts
Additional comments: 1
src/components/sq-modal/sq-modal.component.html (1)
  • 24-26: The implementation of the *ngIf directive to conditionally render the close button based on the buttonClose property looks correct. Ensure that the buttonClose property is properly initialized and managed within the component's TypeScript file.

@dyelmag dyelmag merged commit c4ede03 into master Dec 22, 2023
@dyelmag dyelmag deleted the modal-close-button branch December 22, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants