feature/SQ-62773-problema-no-scroll

[JonasPeres]

https://duopana.myjetbrains.com/youtrack/issue/SQ-62773/PORTAL-Problema-de-responsividade.

Summary by CodeRabbit

• New Features
  • Enhanced modal and overlay components to track and handle window scroll position, improving user experience during interaction.

[coderabbitai]

Walkthrough

The recent updates focus on enhancing user experience by managing the scroll position more effectively in modal and overlay components. These changes ensure that the window's scroll position is preserved and handled smoothly when modals and overlays are added or removed. Additionally, unnecessary event listeners are cleaned up, streamlining performance and user interaction.

Changes

File Path	Summary
.../sq-modal/sq-modal.component.ts & .../sq-overlay/sq-overlay.component.ts	- Introduced scrollY to monitor window scroll. - Refined logic for DOM manipulation and scroll management. - Removed keydown event listener in modal component.

🐰✨
In the realm of code, where the elements play,
A rabbit hopped in, tweaking overlays.
Scroll positions fixed, with a magical twist,
No more lost places, in the scrollable mist.
So here's to the changes, may they serve you right,
As you navigate pages, from morning till night.
🌟📜🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[JonasPeres]

@vinimarcili code review

[coderabbitai]

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 6c1f90b and aa99764.

Files ignored due to path filters (2)

• package-lock.json is excluded by: !**/*.json
• src/package.json is excluded by: !**/*.json

Files selected for processing (2)

• src/components/sq-modal/sq-modal.component.ts (4 hunks)
• src/components/sq-overlay/sq-overlay.component.ts (5 hunks)

Additional comments: 6

src/components/sq-modal/sq-modal.component.ts (3)

• 149-149: The addition of the scrollY property to track the window's scroll position is a good approach to handle scroll behavior when the modal is active. This ensures that the user's scroll position is preserved, enhancing the user experience.
• 175-175: Storing the current scroll position in this.scrollY when the modal is opened is a crucial step for restoring the scroll position later. This is a good practice for maintaining the user experience when modals are involved.
• 241-241: Removing the keydown event listener when the modal is removed is a good practice to clean up event listeners and prevent potential memory leaks. This ensures that the component does not continue to react to keydown events after it has been destroyed or is no longer in use.

src/components/sq-overlay/sq-overlay.component.ts (3)

• 203-203: The addition of the scrollY property to track the window's scroll position is consistent with the changes made in the sq-modal component. This property is crucial for preserving the user's scroll position when overlays are displayed, contributing to a better user experience.
• 232-232: Storing the current scroll position in this.scrollY when the overlay is opened is a good practice. This ensures that the scroll position can be restored accurately when the overlay is closed, maintaining a smooth user experience.
• 303-303: Removing the keydown event listener when the overlay is removed aligns with best practices for event listener management. This cleanup step is essential for preventing memory leaks and ensuring that the component does not respond to keydown events after it is no longer active.