-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Export setAllComponentsTranslations function #13
Conversation
WalkthroughThis update enhances the application's localization and user interface components, introducing new input types and expanding translation support across different languages. Key changes include version increment, addition of new components ( Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (27)
Files skipped from review due to trivial changes (7)
Additional comments not posted (24)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
state.error = t('required') | ||
} else if (!validatorHelper.date(state.value)) { | ||
state.error = t('invalidDate') | ||
} else if (maxDate && new Date(state.value) > new Date(maxDate)) { | ||
state.error = t('biggerThanMaxDate', { maxDate: new Date(maxDate).toLocaleDateString(i18n?.language) }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validate date input against maximum date constraint.
The validation for the maximum date uses the translation key 'biggerThanMaxDate'. Ensure that this validation correctly compares the input date against the maxDate
prop and that the error message is appropriately displayed.
Summary by CodeRabbit
SqInputDate
andSqInputFile
, including their styling and integration into the application.package.json
from "0.0.11" to "0.0.12".SqInputDate
component.