User Context Tweaks #282
User Context Tweaks #282
Conversation
|
The message::Source::User should be resolved with attributes. We do this in data::message when constructing it. The reason you might see attributes missing is because this uses the attributes from our client state at the time we receive the message. If you first load Halloy and get a backlog of messages from your bouncer, these probably come in before we resolve WHO messages to update client state with attributes. @casperstorm and I are aware of this potential gap. The upside of doing it this way however is old messages more accurately reflect permissions at the time the message was sent (ignoring the initial backlog timing issue). We need to align on if we want to address this and maybe use some type safety to ensure we're always working with the desired user type. |
|
Ahh, my apologies you're absolutely correct. I was testing with messages sent before attribute levels were changed. And, as you mention, the way I implemented this will reflect an inaccurate message history wrt attributes. Maybe the op context menu items could be only present in the nick_list? Regardless, I'll remove that part of this PR. |
andymandias
force-pushed
the
user-context-tweaks
branch
from
61d2179
to
8799877
Compare
src/buffer/channel.rs
Outdated
| let users = clients.get_channel_users(&state.server, &state.channel); | ||
| let our_user = users | ||
| .iter() | ||
| .find(|user| user.nickname() == our_nick.unwrap()); |
There was a problem hiding this comment.
We have a clients.resolve_attributes you can use
There was a problem hiding this comment.
Thanks for the heads up!
|
Can you add a entry to CHANGELOG as well? |
|
I promise one of these days I'll remember to update changelog 😅 |
andymandias
force-pushed
the
user-context-tweaks
branch
from
262362c
to
d3fd9fe
Compare
casperstorm
force-pushed
the
user-context-tweaks
branch
from
d3fd9fe
to
45d5341
Compare
|
Rebased on master. Tested and works great. |
Two minor tweaks related to the new user context functionality:
message::Source::User(user)is being constructed from proto::User, which always has the default access levels. I didn't see a simple way to add the user lookup tomessage::Source::Userconstruction, so I added it to the channel view.I can split these up if one is desirable and the other is not.