Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core.edn doesn't update when I export new vars in core.js #294

Closed
lilactown opened this issue Feb 20, 2023 · 4 comments
Closed

core.edn doesn't update when I export new vars in core.js #294

lilactown opened this issue Feb 20, 2023 · 4 comments

Comments

@lilactown
Copy link
Collaborator

Editing core.js, I cannot convince bb dev or bb build to use the core.js file on disk to update core.edn.

@borkdude
Copy link
Member

Try wiping the .shadow-cljs directory first

@lilactown
Copy link
Collaborator Author

I "fixed" it by copying the core.js file to node_modules/squint-cljs/core.js, since that's where the bb tasks look to get the exports.

Seems like it ought to look at ./core.js instead. I can open a PR if that's the case.

@borkdude
Copy link
Member

borkdude commented Feb 20, 2023 via email

@borkdude
Copy link
Member

I think you just need to call npm install and then it will create a symlink from node_modules to the current directory:

 $ ls -la node_modules/squint-cljs
lrwxr-xr-x  1 borkdude  staff  2 Dec 27 17:25 node_modules/squint-cljs -> ..

This will allow you to make changes locally in core.js and immediately use them in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants