Optimizing conj and assoc and making their behavior match clj's more closely #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilactown
reviewed
Aug 14, 2022
fixes for tests
corasaurus-hex
changed the title
|
Appreciate this PR! Thanks a lot. I do prefer to work in small PRs that don't add a ton of stuff in one go, so it's easier to review. About About prettier: why is cc @lilactown |
|
Did some benchmarking and found that using an imperative counter is faster than using |
Closed
borkdude
added a commit
that referenced
this pull request
Dec 24, 2022
…closely (#17) * WIP optimizing conj and assoc and making their behavior more match clj's * fix conj tests * fix calling namespace on non-kw in map emit * Fix some bugs in assoc/conj and add more tests for them * Fill out the remainder of tests and fix more bugs * Remove some prettier formatting that was accidentally applied * Bonus get + assoc-in + assoc-in! * Added tests for str and optimized it. Co-authored-by: Will Acton <will@willacton.com> Co-authored-by: Michiel Borkent <michielborkent@gmail.com>
wearethebork
pushed a commit
that referenced
this pull request
Dec 25, 2022
borkdude
added a commit
that referenced
this pull request
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These appear to be significantly faster than the original functions and handle more corner cases in order to more closely match clojure's conj/assoc functions.
EDIT: I added get + assoc-in + assoc-in! as a bonus on this PR, and sped up str / added tests for it.