Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise validation error for all zero response data #148

Conversation

Darsstar
Copy link
Contributor

@Darsstar Darsstar commented Apr 2, 2024

Succeeds #142, thanks @VadimKraus.

@VadimKraus
Copy link
Contributor

how about we just reopen #142 :D

@Darsstar
Copy link
Contributor Author

Darsstar commented Apr 2, 2024

how about we just reopen #142 :D

I can't. Feel free to rebase your branch on master yourself.

@VadimKraus
Copy link
Contributor

Ah sorry, there were conflicts again? nvm then :P

@Darsstar Darsstar force-pushed the raise-error-all-zero-data-credits-to-VadimKraus branch from 708efaf to d0e57d3 Compare May 4, 2024 21:53
@joseal
Copy link

joseal commented May 16, 2024

@Darsstar, could you please confirm if this change was already merged/deployed? sorry, because I'm already a bit confused...

@Darsstar
Copy link
Contributor Author

For all intents and purposes: no, it has not.

@squishykid squishykid merged commit fedda9d into squishykid:master Jun 5, 2024
6 checks passed
@Darsstar Darsstar deleted the raise-error-all-zero-data-credits-to-VadimKraus branch June 5, 2024 11:15
@squishykid
Copy link
Owner

This change is included in the new release: https://pypi.org/manage/project/solax/release/3.1.1/

If this should be upstreamed into home-assistant, do you mind raising a PR there to update the library? Here is an example of a previous library version bump: https://github.com/home-assistant/core/pull/114617/files#diff-35e8156540ea3b627a1b0b99df30998d35e88a2176c315c8f2cdc0cd972ebaf4

@Darsstar
Copy link
Contributor Author

Darsstar commented Jun 5, 2024

This change is included in the new release: https://pypi.org/manage/project/solax/release/3.1.1/

If this should be upstreamed into home-assistant, do you mind raising a PR there to update the library? Here is an example of a previous library version bump: https://github.com/home-assistant/core/pull/114617/files#diff-35e8156540ea3b627a1b0b99df30998d35e88a2176c315c8f2cdc0cd972ebaf4

I went ahead and created home-assistant/core#118888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants