Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object using aria-labelledby as text alternative incorrectly flagged as error #159

Closed
robfentress opened this issue Feb 29, 2016 · 3 comments
Labels

Comments

@robfentress
Copy link

An object that is given alternate text using aria-labelledby is incorrectly flagged as an error. This is the code that threw the error:

<p><object data="x.jpg" aria-labelledby="monkey"></object></p>
<div id="monkey">My monkey</div>

The error given is:

Object elements must contain a text alternative after all other alternatives are exhausted.

@ironikart
Copy link
Contributor

Not sure how accurate/current the data is but it looks like many screen readers do not support aria-labelledby attribute on many elements: http://www.powermapper.com/tests/screen-readers/aria/. Notably the object element is missing from all the ones tested.

@robfentress
Copy link
Author

I've since found that, though, technically, using aria-labelledby for alternative text for objects is okay, the support for this is inconsistent, especially in Windows-Eyes and NVDA with Firefox, so the case for changing this one is diminished, as you note. Sorry.

@robfentress
Copy link
Author

Correction again: When I used a real URL for the data source and set the width and height, NVDA worked fine, so I guess the issue comes down to whether you think Window-Eyes has enough market share to warrant inclusion. For me, Window-Eyes crashes constantly, so I find it hard to believe it is used as much as the WebAim survey suggests, but I guess it is the best we've got.

ironikart added a commit that referenced this issue Aug 25, 2016
…ledby and aria-label will be picked up as one of the required attributes on specified element types and checked for validity. This addresses #160 and paves the way for #159, #158, #157 and #156. Also references #162.
ironikart added a commit that referenced this issue Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants