Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to support UMD format #166

Closed
wants to merge 1 commit into from
Closed

Conversation

jardilio
Copy link

Added support for UMD format so that this class can be easily imported into a module system

Added support for UMD format so that this class can be easily imported into a module system
@ironikart
Copy link
Contributor

ironikart commented Aug 25, 2016

I've changed the build script (grunt build and grunt build-debug) to output a file wrapped in UMD in this commit f79cf0a.

It should be noted that the code itself isn't fully modular, there are a lot of references to browser document and window objects which for obvious reasons cannot be changed, but the built file can be imported into a CommonJS or AMD system as long as those requirements are taken care of elsewhere. In this case the UMD format makes it quite useful if you are using something like Browserify for your builds and you want to bring in HTMLCS as a dependency.

Also note this does not mean HTML_CodeSniffer is supported by Node. I've added a Node & JSDom example as a starting point for those wishing to explore a full server side implementation of HTML_CodeSniffer.

@ironikart ironikart closed this Aug 25, 2016
@leny leny mentioned this pull request Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants