Using isset() for performance (ref #2003)

squizlabs · Apr 23, 2018 · 79d5fdf · 79d5fdf
1 parent 89484c2
commit 79d5fdf
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/src/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php b/src/Standards/Squiz/Sniffs/Operators/ComparisonOperatorUsageSniff.php
@@ -32,13 +32,13 @@ class ComparisonOperatorUsageSniff implements Sniff
      * @var array
      */
     private static $validOps = [
-        T_IS_IDENTICAL,
-        T_IS_NOT_IDENTICAL,
-        T_LESS_THAN,
-        T_GREATER_THAN,
-        T_IS_GREATER_OR_EQUAL,
-        T_IS_SMALLER_OR_EQUAL,
-        T_INSTANCEOF,
+        T_IS_IDENTICAL        => true,
+        T_IS_NOT_IDENTICAL    => true,
+        T_LESS_THAN           => true,
+        T_GREATER_THAN        => true,
+        T_IS_GREATER_OR_EQUAL => true,
+        T_IS_SMALLER_OR_EQUAL => true,
+        T_INSTANCEOF          => true,
     ];
 
     /**
@@ -157,15 +157,15 @@ public function process(File $phpcsFile, $stackPtr)
 
         for ($i = $start; $i <= $end; $i++) {
             $type = $tokens[$i]['code'];
-            if (in_array($type, array_keys(self::$invalidOps[$tokenizer])) === true) {
+            if (isset(self::$invalidOps[$tokenizer][$type]) === true) {
                 $error = 'Operator %s prohibited; use %s instead';
                 $data  = [
                     $tokens[$i]['content'],
                     self::$invalidOps[$tokenizer][$type],
                 ];
                 $phpcsFile->addError($error, $i, 'NotAllowed', $data);
                 $foundOps++;
-            } else if (in_array($type, self::$validOps) === true) {
+            } else if (isset(self::$validOps[$type]) === true) {
                 $foundOps++;
             }