Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very large reports can sometimes become garbled when using the parallel option #1746

Closed
b0nd0 opened this issue Nov 8, 2017 · 1 comment
Closed
Milestone

Comments

@b0nd0
Copy link

b0nd0 commented Nov 8, 2017

I used --parallel=10 with --report=json on our legacy codebase, and got almost 60 megabytes error report with invalid json inside.
Some parts overlaps, like some kind of race conditions:

...,"source":"Generic.WhiteSpace.ScopeIndent.IncorrectEx"\/another\/file\/path\/file.php":{"errors":159,"warnings":7,...
@gsherwood gsherwood changed the title race conditions in --parallel Very large reports can sometimes become garbled when using the parallel option Nov 8, 2017
gsherwood added a commit that referenced this issue Nov 8, 2017
@gsherwood
Copy link
Member

Thanks for reporting this. A lock wasn't being acquired when appending a cached report to the temp file, so I've fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants