Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sniff with T_RETURN_TYPE not triggered at all #2049

Closed
Majkl578 opened this issue Jun 7, 2018 · 2 comments
Closed

Sniff with T_RETURN_TYPE not triggered at all #2049

Majkl578 opened this issue Jun 7, 2018 · 2 comments

Comments

@Majkl578
Copy link
Contributor

Majkl578 commented Jun 7, 2018 •
edited

Sniffs that are registered for T_RETURN_TYPE are not triggered at all. Therefore sniffs for return type colon spacing do not work.

This completely breaks Slevomat Coding Standard and Doctrine Coding Standard.

https://travis-ci.org/doctrine/coding-standard/builds/389215937
downstream tracking issue for PHPCS 3.3: slevomat/coding-standard#360
@Majkl578 Majkl578 mentioned this issue Jun 7, 2018
Closed
@jrfnl
Copy link
Contributor

jrfnl commented Jun 7, 2018 •
edited

Please read the changelog for PHPCS 3.3.0 and issue #1527 for the discussion around this.

@gsherwood gsherwood added this to Track in PHPCS v3 Development Jun 7, 2018
@Dinamiko Dinamiko mentioned this issue Jun 13, 2018
Closed
PHPCS v3 Development automation moved this from Track to Ready for Release Jul 4, 2018
@gsherwood gsherwood removed this from Ready for Release in PHPCS v3 Development Jul 4, 2018
@Majkl578
Copy link
Contributor Author

Majkl578 commented Jul 4, 2018

Sorry, I really have no words if you truly think BC breaks like this are ok in a minor release. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Majkl578 @gsherwood @jrfnl