Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return code of phpcbf on all errors fixed #2954

Closed
Tezd opened this issue May 7, 2020 · 2 comments
Closed

Return code of phpcbf on all errors fixed #2954

Tezd opened this issue May 7, 2020 · 2 comments

Comments

@Tezd
Copy link

Tezd commented May 7, 2020

I have a question regarding this part of the code
https://github.com/squizlabs/PHP_CodeSniffer/blob/master/src/Runner.php#L223
It will return 1 even if all errors are resolved which later will be set as exit code here
https://github.com/squizlabs/PHP_CodeSniffer/blob/master/bin/phpcbf#L19
Everything which is not 0 considered to be error code.
But in that case it fixed everything should it return 0 instead ?

@jrfnl
Copy link
Contributor

jrfnl commented May 7, 2020

Duplicate of #1359

Also see: #1818 (comment)

A revision of the exit codes in on the roadmap for PHPCS 4.x. See #2898

@Tezd Tezd closed this as completed May 8, 2020
@Tezd
Copy link
Author

Tezd commented May 8, 2020

Thank you, couldn't find it in issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants