Undefined index error with pre-commit hook using husky on PHP 7.4

[ivuorinen]

For some unknown reason, doing git pre-commit hook with husky and PHP 7.4, FileList method current tries to access undefined array index and throws RuntimeException.

✖ vendor/bin/phpcs --standard=phpcs.xml web/app/ config/ found some errors. Please fix them and try committing again.
.....
Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: Undefined index:  in vendor/squizlabs/php_codesniffer/src/Files/FileList.php on line 187 in vendor/squizlabs/php_codesniffer/src/Runner.php:606
Stack trace:
#0 vendor/squizlabs/php_codesniffer/src/Files/FileList.php(187): PHP_CodeSniffer\Runner→handleErrors(8, 'Undefined index...', '/Users/ivuorine...', 187, Array)
#1 vendor/squizlabs/php_codesniffer/src/Runner.php(487): PHP_CodeSniffer\Files\FileList→current()
#2 vendor/squizlabs/php_codesniffer/src/Runner.php(114): PHP_CodeSniffer\Runner→run()
#3 vendor/squizlabs/php_codesniffer/bin/phpcs(18): PHP_CodeSniffer\Runner→runPHPCS()
#4 {main}
thrown in vendor/squizlabs/php_codesniffer/src/Runner.php on line 606
.......�[33mW�[0m......�[33mW�[0m...�[33mW�[0m.�[33mW�[0m....�[33mW�[0m...�[31mE�[0m. 36 / 36 (100%)

After adding the isset($this->files[$path]) === false check, linting works as expected.

✖ vendor/bin/phpcs --standard=phpcs.xml web/app/ config/ found some errors. Please fix them and try committing again.
�[33mW�[0m...............�[33mW�[0m.......�[33mW�[0m....�[33mW�[0m.�[31mE�[0m�[33mW�[0m... 36 / 36 (100%)

[ivuorinen]

@gsherwood Sorry to ping you, but could you check this out?

[gsherwood]

I couldn't figure out how to replicate this, but the isset() statement is a good alternative to the null comparison anyway, and if that gets this working then all the better. I ended up removing the null comparison because it was doing the same thing anyway. The new commit is here: 072042a

Thanks for finding and fixing this.