Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InlineControlStructureSniff fails to fix when statement has no semicolon #400

Closed
intersvyaz-it opened this issue Dec 27, 2014 · 3 comments
Closed

Comments

@intersvyaz-it
Copy link

test.php:

<div style="text-align: right;">
    <?php if ($model->scenario == 'simple') $widget->renderPager() ?>
</div>

command:

phpcbf --standart="PSR2" test.php

Output

=> Fixing file: 1/1 violations remainingPHP Notice:  Undefined offset: 23 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php on line 156
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP Notice:  Undefined offset: 23 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 313
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->addContent() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:164
PHP  12. PHP_CodeSniffer_Fixer->getTokenContent() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:618
PHP Notice:  Undefined offset: 23 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 449
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->endChangeset() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:176
PHP  12. PHP_CodeSniffer_Fixer->replaceToken() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:354
PHP Notice:  Undefined offset: 23 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 478
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->endChangeset() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:176
PHP  12. PHP_CodeSniffer_Fixer->replaceToken() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:354
        => Fixing file: 2/1 violations remaining [made 1 pass]... PHP Notice:  Undefined offset: 26 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php on line 156
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP Notice:  Undefined offset: 26 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 313
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->addContent() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:164
PHP  12. PHP_CodeSniffer_Fixer->getTokenContent() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:618
PHP Notice:  Undefined offset: 26 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 449
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->endChangeset() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:176
PHP  12. PHP_CodeSniffer_Fixer->replaceToken() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:354
PHP Notice:  Undefined offset: 26 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 478
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->endChangeset() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:176
PHP  12. PHP_CodeSniffer_Fixer->replaceToken() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:354
        => Fixing file: 2/1 violations remaining [made 2 passes]... PHP Notice:  Undefined offset: 28 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php on line 156
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP Notice:  Undefined offset: 28 in /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php on line 313
PHP Stack trace:
PHP   1. {main}() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:0
PHP   2. PHP_CodeSniffer_CLI->runphpcbf() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/scripts/phpcbf:23
PHP   3. PHP_CodeSniffer_CLI->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:164
PHP   4. PHP_CodeSniffer->processFiles() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/CLI.php:854
PHP   5. PHP_CodeSniffer->processFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:618
PHP   6. PHP_CodeSniffer_Reporting->cacheFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer.php:1677
PHP   7. PHP_CodeSniffer_Reports_Diff->generateFileReport() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reporting.php:158
PHP   8. PHP_CodeSniffer_Fixer->fixFile() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Reports/Diff.php:68
PHP   9. PHP_CodeSniffer_File->start() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:182
PHP  10. Generic_Sniffs_ControlStructures_InlineControlStructureSniff->process() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:568
PHP  11. PHP_CodeSniffer_Fixer->addContent() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php:164
PHP  12. PHP_CodeSniffer_Fixer->getTokenContent() /home/miramir/.cache/composer/vendor/squizlabs/php_codesniffer/CodeSniffer/Fixer.php:618
        => Fixing file: 0/1 violations remaining [made 3 passes]... DONE in 9ms 
@miramir
Copy link

miramir commented Dec 27, 2014

php-codesniffer install by

composer global require --prefer-dist "squizlabs/php_codesniffer:dev-master"

@aik099
Copy link
Contributor

aik099 commented Dec 27, 2014

@gsherwood gsherwood changed the title Undefined offset in phpcbf InlineControlStructureSniff fails to fix when statement has no semicolon Jan 5, 2015
gsherwood added a commit that referenced this issue Jan 5, 2015
@gsherwood
Copy link
Member

The issue was caused by no semicolon at the end of the statement. I've corrected this now and the sniff sees the close tag as the end instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants