PHPCBF no-patch option shows an error when there are no fixable violations in a file

[aik099]

Here is the fragment of phpcbf output:

Processing upgrades.php [PHP => 642 tokens in 70 lines]... DONE in 38ms (1 fixable violations)
        => Fixing file: 0/1 violations remaining [made 2 passes]... DONE in 96ms
    => File was overwritten
Processing constants.php [PHP => 1292 tokens in 228 lines]... DONE in 83ms (0 fixable violations)
    => Fixing file: 0/0 violations remainingERROR in 0ms

I guess when 0 fixing passes were made, then [made 0 passes]... isn't printed and ERROR word has no space before it and remaining word.

[gsherwood]

When I run phpcbf over a file with 0 fixable violations, the output I get is:

Processing temp.php [PHP => 6 tokens in 2 lines]... DONE in 1ms (0 fixable violations)
No fixable errors were found

How are you running phpcbf to make it generate that error?

[aik099]

I'm using this command:

phpcbf --standard=/path/to/project/vendor/aik099/coding-standard/CodingStandard -wps --no-patch --encoding=UTF-8 --extensions=php -d memory_limit=-1 ../../modules/custom/constants.php

The constants.php file is:

<?php
// product types.
define('PRODUCT_TYPE_RETAIL', 1);
define('PRODUCT_TYPE_MANUFACTURED', 10);

The output is the same:

Changing into directory /path/to/project/modules/custom
Processing constants.php [PHP => 20 tokens in 4 lines]... DONE in 3ms (0 fixable violations)
    => Fixing file: 0/0 violations remainingERROR in 0ms
Fixed 0 files
Time: 54ms; Memory: 4.75Mb

[gsherwood]

Thanks for providing that. It's the --no-patch option that is printing the output incorrectly.

[aik099]

Thanks.