Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call-time pass-by-reference false positive #672

Closed
bwhitty opened this issue Aug 5, 2015 · 1 comment
Closed

Call-time pass-by-reference false positive #672

bwhitty opened this issue Aug 5, 2015 · 1 comment
Labels
Type: bug

Comments

@bwhitty
Copy link

bwhitty commented Aug 5, 2015

Running phpcs as follows

phpcs --standard=Generic --extensions=php --sniffs=Generic.Functions.CallTimePassByReference -pvs ./

throws an error in the phpseclib file found here: https://github.com/phpseclib/phpseclib/blob/0.3.8/phpseclib/File/X509.php#L4382

This does not fail a PHP lint check when running 5.4+.
gsherwood added a commit that referenced this issue Aug 20, 2015
@gsherwood
Fixed bug #672 : Call-time pass-by-reference false positive
e4b7736
@gsherwood
Copy link
Member

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsherwood @bwhitty