Unused use statement rule

[alexwhitman]

Is there a rule to detect unused use statements? For example:

<?php

use Foo\Bar;
use Foo\Baz; // This should be detected as unused

class MyClass
{
    public function doSomething(Bar $bar)
    {
        // .....
    }
}

PHP-CS-Fixer has an unused_use fixer but I'd prefer to use the one tool if possible.

[aik099]

Nope.

For a questions you can use our Gitter channel: https://gitter.im/squizlabs/PHP_CodeSniffer

[klausi]

There is a sniff for that in Drupal's coder: https://www.drupal.org/project/coder

[ExplodingCabbage]

I just wanted this feature and was considering writing my own sniff. @klausi, as the owner of coder would you have any objection to PHPCS nicking the UnusedUseStatementSniff and putting it into the generic section of PHPCS? It looks pretty solid to my (non-expert) eye, and I'm sure that more people would be able to benefit from it if it were put into the core of PHPCS; I'd prefer not to replicate your work by writing my own to PR into here.

(If you're okay with it, I'm also interested to look over coder for other non-Drupal-specific sniffs that could happily live in PHPCS and start migrating them. It looks like you've got a lot of cool stuff over there!)

[klausi]

Coder is GPLv2+ licensed and PHPCS is MIT, so you need to get copyright permission from all authors of a sniff when you want to pull in sniffs from Coder to PHPCS for MIT relicensing. Which is totally fine with me, so you have my permission to do that. In the case of UnusedUseStatementSniff we also need to ask @alexpott (the only other author).

[alexpott]

Fine by me.

[patrickallaert]

Looks like @alexpott agreed, can it be included?
Thanks in advance.

[ExplodingCabbage]

@patrickallaert there's already an in-progress PR to include this.

[TomasVotruba]

Alread in no_unused_imports [@Symfony]: https://github.com/friendsofphp/php-cs-fixer

[juuuuuu]

I think this issue can be closed. Or is it still in disucssion? :)